Fix WorkerInstanceKey not forwarded between task queue partitions#9214
Merged
Fix WorkerInstanceKey not forwarded between task queue partitions#9214
Conversation
dnr
reviewed
Feb 4, 2026
When workflow or activity poll requests are forwarded from one partition to another, the WorkerInstanceKey field was not being copied to the forwarded request. This caused the worker's instance key to be lost. Changes: - Add workerInstanceKey field to pollMetadata struct - Populate workerInstanceKey from request in PollWorkflowTaskQueue - Populate workerInstanceKey from request in PollActivityTaskQueue - Forward workerInstanceKey in Forwarder.ForwardPoll for both task types - Forward workerInstanceKey in ForwardPollWithTarget (pri_forwarder) - Add tests to verify WorkerInstanceKey is preserved during forwarding
rkannan82
force-pushed
the
kannan/fix-worker-instance-key-forwarding
branch
from
146ad04 to
07def54
Compare
dnr
approved these changes
Feb 5, 2026
rkannan82
force-pushed
the
kannan/fix-worker-instance-key-forwarding
branch
2 times, most recently
from
e1a5a1a to
1fcb0df
Compare
dnr
reviewed
Feb 5, 2026
rkannan82
force-pushed
the
kannan/fix-worker-instance-key-forwarding
branch
from
1fcb0df to
07def54
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
We will be recording the WorkerInstanceKey in the ActivityInfo as part of task matching. This will be used later to send activity cancellation tasks to that worker.
How did you test it?
Potential risks